このサイトを正しく表示するには、最新のブラウザを使用し、Javascriptを有効化してください。

Memory management of character with many outfits

dreamau

Hi Harald,

That makes perfect sense, but the create skin is still not showing. I emailed you the small repro project to the email you've given me.
For reference and benefit of others, here's the code I've tried:

public class Root : MonoBehaviour
{
    public SkeletonDataAsset Body;
    SkeletonAnimation _bodySkeletonAnimation;

public SkeletonDataAsset Outfit;

void Start()
{
    _bodySkeletonAnimation = SkeletonAnimation.NewSkeletonAnimationGameObject(Body);
    var bodySkeletonData = Body.GetSkeletonData(true);

    var outfitSkeletonData = Outfit.GetSkeletonData(true);
    var outfitSkin = outfitSkeletonData.DefaultSkin;

    var customSkin = new Skin("custom-skin");

    foreach (var attachement in outfitSkin.Attachments)
    {
        var slotIndex = attachement.SlotIndex;
        var slotName = outfitSkeletonData.Slots.Items[slotIndex].Name;
        int bodySlotIndex = bodySkeletonData.FindSlotIndex(slotName);

        if (bodySlotIndex >= 0)
        {
            Debug.Log("attaching " + attachement.Name + " to slot index " + bodySlotIndex + ", slotName: " + slotName + ", outfit slot index: " + slotIndex);
            customSkin.SetAttachment(bodySlotIndex, slotName, attachement.Attachment);
        }
    }

    _bodySkeletonAnimation.Skeleton.SetSkin(customSkin);
    _bodySkeletonAnimation.Skeleton.SetSlotsToSetupPose();

    _bodySkeletonAnimation.AnimationState.Apply(_bodySkeletonAnimation.Skeleton);
}
}

Harald

Sorry to hear that it's not working as desired yet. Thanks for sending the reproduction project, we received everything. We will have a look at it and will get back to you once we've figured out what's going wrong.

The problem with your project seems that there are missing slots in your body skeleton. You are trying to attach e.g. JuliaArmor/belt to slot named belt, but this slot does not exist in your body skeleton. Same goes for all other slots that fail to be attached (with a returned slotIndex or -1 at FindSlotIndex()).

Are you sure that these slots existed in the original body Spine project? If so, could you please check your export settings or share some screenshots of the export settings you used?

dreamau

Hi Harald,

Thanks for this. I agree some slots are missing, and it's expected those attachment do not get attached.
But why are the attachments for existing matching slots not getting attached. I log out the matching slots that exist and I try to attach to it, but it does not render. Example of the log:

attaching JuliaArmor/footL to slot index 0, slotName: footR, outfit slot index: 1

Here is the slot on the body (from Julia_bdy_noX.json) - it's currently at index 0:

"slots": [
   { "name": "footR", "bone": "P_FootR", "attachment": "JuliaNude/footR" },
        ....

Here is the same slot on the outfit (Julia_Armor_noX.json) - slot as index 1 (that is ok as you mentioned), attached to the bone of the same name P_FootR (but this likely does not matter)

"slots": [
   { "name": "pantLegR", "bone": "P_hips", "attachment": "JuliaArmor/pantLegR" },
   { "name": "footR", "bone": "P_FootR", "attachment": "JuliaArmor/footL" },

and here is the attachement on the outfit, which it's referencing.

"footL": {
   "JuliaArmor/footL": {
      "type": "mesh",

I would expect some attaachements from the outfit to show up on the body (log has about 10 valid matches), but none do .. The scene only has a single draw call (using body texture), and no draw call using outfit texture.

Harald

Oh, I see. I have been misled by your project setup of the missing attachments, and I incorrectly assumed that e.g. JuliaArmor/footL was intended to show the naked foot attachment, but it is instead intended to show an armoured boot. I will have another look at your project and will get back to you when we've figured it out.

The problem turned out to be that all your attachments are successfully set, but they are just not shown in setup pose. E.g. you have Slot forearmL and in the setup pose you have attachment JuliaNude/forearmL active. Now you add the attachment JuliaArmor/forearmL at the same slot, but never switch to this attachment at the slot, keeping the setup pose attachment JuliaNude/forearmL active of the two attachments.

A nice tool for testing such issues is opening the Skeleton Debug window (SkeletonAnimation Inspector - Advanced - Debug) and inspect all slots.

The difference to the Goblins project, and why it works out-of-the-box there, is that in the Goblins project, a skin placeholder is used at each slot.
E.g. in the goblins base skeleton.json:

"slots": [
    { "name": "left-shoulder", "bone": "left-shoulder", "attachment": "left-shoulder" },

and in the skin goblins.json file this skin placeholder is set:

"slots": [
   { "name": "left-shoulder", "bone": "left-shoulder", "attachment": "left-shoulder" },
"skins":
    ..
    "left-shoulder": {
        "left-shoulder": {
            "name": "goblin/left-shoulder",

In contrast, in your projects there seems to be no skin placeholder name used, but instead directly the default attachment name is referenced:

"slots": [
   { "name": "footR", "bone": "P_FootR", "attachment": "JuliaNude/footR" },

while in the skin .json file it is referencing JuliaArmor/footL:

"slots": [
   { "name": "footR", "bone": "P_FootR", "attachment": "JuliaArmor/footL" },
...
"skins":
    ..
    "footR": {
        "JuliaArmor/footL"

This will then not be replaced by the SetSkin() call, but will instead be added as a second attachment.

So please check whether you are using skin placeholders with the same name in both projects, then it will work without any additional code required.

dreamau

Thanks for all the help so far. I got the prototype to an acceptable state, and now I'm exploring the other option, where in the prefabs I strip out the textures (and replace them by 1 pixel white textures). This bit works, and when I load the character at runtime, all is white as expected and no large textures are loaded.

I need to load those original large textures or materials with them at runtime on demand, when I need to use a specific skin. And I'm not sure where to find the materials / textures that are used at runtime, so that I can replace them / swap textures on them. I see that SpineAtlasAsset class stores an array of materials .. but how do I get to its instance at runtime, from the SkeletonData / SkeletonDataAsset?

Harald

dreamau wrote
but how do I get to its instance at runtime, from the SkeletonData / SkeletonDataAsset?

skeletonAnimation.SkeletonDataAsset.atlasAssets holds the array of atlas assets of the base-class type AtlasAssetBase. You can iterate over this array and cast each element to SpineAtlasAsset to access its content.

dreamau

Hi .. Thanks for that, yes I've seen those, and got this working. So I can at startup load all textures and set them up, and the character renders correctly.

But I am trying to do this on demand. Somewhere later I call:

	[code]Skin srcSkin = bodySkeletonData.FindSkin(name);[/code]

and before this I need to load the textures for this skin. So from the skin name I need to go to a specific material or materials inside the SpineAtlasAsset.
I looked at how FindSkin works .. and followed it to Skin class, and from there to SkinEntry and Attachment classes, and from there to MeshAttachment and RegionAttachment, but don't see a way to find out which material I need to load.

Harald

Ok, thanks for the additional info, now I understand what you are trying to achieve. We have an issue ticket that shall implement on-demand loading and unloading of material and texture assets according to active skins:
https://github.com/EsotericSoftware/spine-runtimes/issues/1890

Unfortunately a fully automatic solution is not trivial enough to just describe a quick implementation in a few lines. If you decide to implement this feature yourself and not wait for the official implementation, I would recommend adding one layer of indirection (e.g. a new SkinLoader component class) around setting and loading any skin. As a preparation you would then remove all but the default skin's assets from any SkeletonDataAsset reference cascades. Then you would set your skin at skinLoader.SetSkin(targetSkeletonAnimation, "skinname") which first checks if it's loaded, loads it on demand and hooks up any references, and then calls targetSkeletonAnimation.Skeleton.SetSkin(skinname). This way it should be doable without having to modify the spine-unity code.

dreamau

And I got it to work .. loading textures on demand when adding skin, and all seems to work. Thanks for your help.
At some point when your solution is ready, we'll probably considering switching to it .. but for now, this works well. What is the ETA for the feature? (within couple of months, or longer?)

Harald

Very glad to hear you've got a working implementation already! :cooldoge:

dreamau wrote
within couple of months, or longer

Exactly that 😉.

cdr9042

Thanks to this thread, I've made a solution to load texture on demand during runtime. It helps reduced texture memory usage by about 40MB (from 131 to 87 MB) in best case scenario (the character equipped few items).

There are 3 things that need to be done:

Set all Spine Atlas's materials' Main Texture to a dummy texture (2x2 white picture).
Know which atlas(es) each items use.
During runtime, when an item is equipped, load the required texture and assign it to the Spine Atlas material.

PictureLoaderEditor: iterate through all the regions in Spine Atlas, get the item name from the region's name then add the atlas's name to the item's data.

SkinAtlasFinder: the editor script handles assigning all the material's Main Texture to a dummy texture so I don't have to do it by hand. The runtime script load the item's data to get the list of atlases that the item uses then load those textures and assigns it to the corresponding material.

Harald

cdr9042 Awesome, thanks very much for sharing! I'm sure your code will help a lot of users! 😎 👍️